Quoting Michal Wajdeczko (2017-12-05 16:38:41) > -EIO has special meaning and is used when we want to allow > engine initialization to fail and mark GPU as wedged. > > However here at this function we should return error code > that corresponds to upload status only, as any decision how > to handle missing firmware should be done higher level function > (silent fallback to non-GuC mode, fail into wedged mode, or > abort driver load with fatal error). > > v2: commit message update (Michal) > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Cc: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx> With my fears expressed elsewhere, Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx