Hi Joonas,
Quoting Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>:
On Mon, 2017-11-27 at 16:17 -0600, Gustavo A. R. Silva wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
I have to say I'm totally not sold on regexps matching comment
contents. Was something more explicit ever considered? Like:
#define FALLTHROUGH __attribute__((fallthrough));
With the appropriate version checks, of course.
One of the arguments is that comments lets us leverage the existing
static analyzers.
We've been discussing this during the last week, feel free to join the
discussion:
http://www.spinics.net/lists/kernel/msg2659908.html
http://www.spinics.net/lists/kernel/msg2659906.html
Thanks!
--
Gustavo A. R. Silva
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
