Quoting Michal Wajdeczko (2017-12-01 10:33:13) > In the upcoming patch we will change the way how to recognize > when GuC is in use. Using helper macros will minimize scope > of that changes. While here, update dev_info message. > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Cc: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx> > --- > drivers/gpu/drm/i915/i915_drv.h | 4 ++++ > drivers/gpu/drm/i915/i915_gem_context.c | 4 ++-- > drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +- > drivers/gpu/drm/i915/i915_irq.c | 2 +- > drivers/gpu/drm/i915/intel_guc.c | 2 +- > drivers/gpu/drm/i915/intel_guc_log.c | 6 +++--- > drivers/gpu/drm/i915/intel_gvt.c | 2 +- > drivers/gpu/drm/i915/intel_uc.c | 23 +++++++++++------------ > drivers/gpu/drm/i915/selftests/intel_guc.c | 2 +- > 9 files changed, 25 insertions(+), 22 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 4c3616b..2c386c7 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -3237,6 +3237,10 @@ intel_info(const struct drm_i915_private *dev_priv) > #define HAS_HUC(dev_priv) (HAS_GUC(dev_priv)) > #define HAS_HUC_UCODE(dev_priv) (HAS_GUC(dev_priv)) > > +/* Having a GuC is not the same as using a GuC */ > +#define USES_GUC(dev_priv) (i915_modparams.enable_guc_loading) > +#define USES_GUC_SUBMISSION(dev_priv) (i915_modparams.enable_guc_submission) I was thinking that maybe we should keep the HAS_GUC here until the end, but afaict the modparam is always sanitized by the point we inspect it for USES_GUC. Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
