On Wed, Nov 22, 2017 at 11:44:32PM +0000, Pandiyan, Dhinakaran wrote:
> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx> for the
> series.
Series pushed. Thanks for the review.
>
>
> On Tue, 2017-11-21 at 20:49 +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> >
> > I think the dump is a more legible when the register names
> > are right justified. That way the register name and its value
> > are right next to each other.
> >
> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> > ---
> > tools/intel_watermark.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/tools/intel_watermark.c b/tools/intel_watermark.c
> > index 3c70f4ec54fb..308e351dcd2f 100644
> > --- a/tools/intel_watermark.c
> > +++ b/tools/intel_watermark.c
> > @@ -248,7 +248,7 @@ static void skl_wm_dump(void)
> > }
> >
> > for (pipe = 0; pipe < num_pipes; pipe++) {
> > - printf("%-18s 0x%08x\t",
> > + printf("%18s 0x%08x\t",
> > skl_wm_linetime_reg_name(pipe),
> > wm_linetime[pipe]);
> > }
> > @@ -260,7 +260,7 @@ static void skl_wm_dump(void)
> > if (plane >= skl_num_planes(devid, pipe))
> > break;
> >
> > - printf("%-18s 0x%08x\t" ,
> > + printf("%18s 0x%08x\t" ,
> > skl_wm_reg_name(pipe, plane, level),
> > wm[level][pipe][plane]);
> > }
> > @@ -274,7 +274,7 @@ static void skl_wm_dump(void)
> > if (plane >= skl_num_planes(devid, pipe))
> > break;
> >
> > - printf("%-18s 0x%08x\t",
> > + printf("%18s 0x%08x\t",
> > skl_wm_trans_reg_name(pipe, plane),
> > wm_trans[pipe][plane]);
> > }
> > @@ -287,7 +287,7 @@ static void skl_wm_dump(void)
> > if (plane >= skl_num_planes(devid, pipe))
> > break;
> >
> > - printf("%-18s 0x%08x\t",
> > + printf("%18s 0x%08x\t",
> > skl_buf_cfg_reg_name(pipe, plane),
> > buf_cfg[pipe][plane]);
> > }
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
