On Fri, Nov 24, 2017 at 03:32:22PM +0100, Philipp Zabel wrote: > On Thu, 2017-11-23 at 21:04 +0200, Ville Syrjala wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > Use drm_mode_get_hv_timing() to fill out the plane clip rectangle. > > > > No functional changes as the code already uses crtc_state->mode > > to populate the clip, which is also what drm_mode_get_hv_timing() > > uses. > > I don't understand this explanation, drm_mode_get_hv_timing uses > whichever mode is passed to it? Hmm. I worded that badly it seems. The point is that we pass the user mode everywhere else where we want to know the dimensions of the crtc coordinate space. > > > Once everyone agrees on this we can move the clip handling into > > drm_atomic_helper_check_plane_state(). > > I can see that there are no functional changes though, > > Acked-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > > regards > Philipp -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
