Re: [PATCH i-g-t] overlay: Fix compiler warning when compiling with meson

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 21/11/2017 13:26, Maarten Lankhorst wrote:
[1/316] Compiling C object 'overlay/intel-gpu-overlay@exe/overlay.c.o'.
../overlay/overlay.c: In function ‘show_gem_objects’:
../overlay/overlay.c:798:31: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 160 [-Wformat-truncation=]
    snprintf(buf, sizeof(buf), "%s %ldMB, %ld objects",
                                ^~
../overlay/overlay.c:798:30: note: using the range [-9223372036854775808, 9223372036854775807] for directive argument
    snprintf(buf, sizeof(buf), "%s %ldMB, %ld objects",
                               ^~~~~~~~~~~~~~~~~~~~~~~
../overlay/overlay.c:798:30: note: using the range [-9223372036854775808, 9223372036854775807] for directive argument
../overlay/overlay.c:798:3: note: ‘snprintf’ output between 16 and 309 bytes into a destination of size 160
    snprintf(buf, sizeof(buf), "%s %ldMB, %ld objects",
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     comm->name, comm->bytes >> 20, comm->count);

Might as well give it the 309 bytes it wants, plus on more. :-)

My bad for not pushing my fix for the same from a few weeks back. a) I was hoping the whole series could go in one, and b) patchwork did not spot the r-b reply I got.

Regards,

Tvrtko

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
---
  overlay/overlay.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/overlay/overlay.c b/overlay/overlay.c
index b30f7a1d66da..4804f813554a 100644
--- a/overlay/overlay.c
+++ b/overlay/overlay.c
@@ -740,7 +740,7 @@ static void init_gem_objects(struct overlay_context *ctx,
  static void show_gem_objects(struct overlay_context *ctx, struct overlay_gem_objects *go)
  {
  	struct gem_objects_comm *comm;
-	char buf[160];
+	char buf[310];
  	cairo_pattern_t *linear;
  	int x, y, y1, y2;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux