Quoting Michal Wajdeczko (2017-11-21 12:04:09)
> On Tue, 21 Nov 2017 12:21:00 +0100, Chris Wilson
> <chris@xxxxxxxxxxxxxxxxxx> wrote:
>
> > Simple va_args equivalent to the existing drm_printf() for use with the
> > drm_printer.
> >
> > v2: Fixup kerneldoc to match final parameter names.
> >
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Rob Clark <robdclark@xxxxxxxxx>
> > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > Cc: Dave Airlie <airlied@xxxxxxxxxx>
> > ---
> > drivers/gpu/drm/drm_print.c | 5 +----
> > include/drm/drm_print.h | 15 +++++++++++++++
> > 2 files changed, 16 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c
> > index 82ff327eb2df..781518fd88e3 100644
> > --- a/drivers/gpu/drm/drm_print.c
> > +++ b/drivers/gpu/drm/drm_print.c
> > @@ -55,13 +55,10 @@ EXPORT_SYMBOL(__drm_printfn_debug);
> > */
> > void drm_printf(struct drm_printer *p, const char *f, ...)
> > {
> > - struct va_format vaf;
> > va_list args;
> > va_start(args, f);
> > - vaf.fmt = f;
> > - vaf.va = &args;
> > - p->printfn(p, &vaf);
> > + drm_vprintf(p, f, &args);
> > va_end(args);
> > }
> > EXPORT_SYMBOL(drm_printf);
> > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
> > index 0968e411f562..d8383d693ad9 100644
> > --- a/include/drm/drm_print.h
> > +++ b/include/drm/drm_print.h
> > @@ -80,6 +80,21 @@ void __drm_printfn_debug(struct drm_printer *p,
> > struct va_format *vaf);
> > __printf(2, 3)
> > void drm_printf(struct drm_printer *p, const char *f, ...);
> > +/*
>
> Proper kernel-doc comments shall start with /**
That's ok then. Preemptive fix (the comment was copied from drm_printf).
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
