Op 20-11-17 om 14:27 schreef Ville Syrjälä: > On Mon, Nov 20, 2017 at 01:23:36PM +0100, Maarten Lankhorst wrote: >> This comment predates atomic, and I think with the way we currently >> track IPS, it's safe to enable this for the case we switch too. >> >> Changes since v1: >> - Keep IPS enabled when switching planes. >> >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> >> --- >> drivers/gpu/drm/i915/intel_display.c | 9 ++------- >> 1 file changed, 2 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c >> index 0b9ba415839a..09817bc6f9a8 100644 >> --- a/drivers/gpu/drm/i915/intel_display.c >> +++ b/drivers/gpu/drm/i915/intel_display.c >> @@ -6237,13 +6237,8 @@ static bool hsw_compute_ips_config(struct intel_crtc_state *pipe_config) >> if (pipe_config->ips_force_disable) >> return false; >> >> - /* >> - * FIXME IPS should be fine as long as one plane is >> - * enabled, but in practice it seems to have problems >> - * when going from primary only to sprite only and vice >> - * versa. >> - */ >> - if (!(pipe_config->active_planes & BIT(PLANE_PRIMARY))) >> + /* IPS should be fine as long as one plane is enabled. */ > Maybe "... at least one plane is enabled." to make it less vague? > >> + if (hweight32(pipe_config->active_planes & ~BIT(PLANE_CURSOR)) != 1) > I keep wondering if popcnt is cheaper than is_power_of_2()? If it is, > maybe someone should actually make is_power_of_2() use popcnt... Crap, should be if (pipe_config->active_planes & ~BIT(PLANE_CURSOR)) > >> return false; >> >> /* HSW can handle pixel rate up to cdclk? */ >> -- >> 2.15.0 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
