Re: [PATCH 4/5] drm/i915: Add a FIXME about FBC vs. fence. 90/270 degree rotation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 16, 2017 at 09:01:03PM +0000, Chris Wilson wrote:
> Quoting Ville Syrjala (2017-11-16 19:14:50)
> > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> > 
> > Currently we're pinning the fence for the rotated GTT view. That doesn't
> > acually make any sense since the fence is used only for the FBC GTT
> > tracking. For that we would want the fence for the normal GTT view
> > instead of the rotated view. Too lazy to fix this now so just add a
> > FIXME.
> 
> The rotated view can't have a fence as its vma is not fenceable.

I see. Doesn't change the fact that it's broken though. I'll see about
rewording this, or maybe I'll even try to fix it.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux