On Tue, Nov 14, 2017 at 11:47:57AM -0800, Rodrigo Vivi wrote: > Accordingly to spec "If Kdiv != 2, then Qdiv must be 1." > but we already handle qdiv values properly and this case here > should be spurious. But instead of blindly replacing let's > warn loudly instead. Because it means something was really > wrong on initial setup. > > Cc: Mika Kahola <mika.kahola@xxxxxxxxx> > Cc: Manasi Navare <manasi.d.navare@xxxxxxxxx> > Cc: James Ausmus <james.ausmus@xxxxxxxxx> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> Reviewed-by: Manasi Navare <manasi.d.navare@xxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_dpll_mgr.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c > index 53f650f56148..bd608f7f2399 100644 > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c > @@ -2184,8 +2184,7 @@ static void cnl_wrpll_params_populate(struct skl_wrpll_params *params, > WARN(1, "Incorrect PDiv\n"); > } > > - if (kdiv != 2) > - qdiv = 1; > + WARN_ON(kdiv != 2 && qdiv != 1); > > params->qdiv_ratio = qdiv; > params->qdiv_mode = (qdiv == 1) ? 0 : 1; > -- > 2.13.6 > _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
