On Tue, 2017-11-14 at 20:32 +0200, Ville Syrjala wrote:
> @@ -253,8 +251,11 @@ struct drm_display_mode {
> * - DRM_MODE_TYPE_USERDEF: Mode defined via kernel command line
> *
> * Plus a big list of flags which shouldn't be used at all, but are
> - * still around since these flags are also used in the userspace ABI:
> + * still around since these flags are also used in the userspace ABI.
> + * We no longer accept modes with these types though:
> *
> + * - DRM_MODE_TYPE_BUILTIN: Meant for hard-coded modes, effectively
> + * unused.
This should suggest _TYPE_DRIVER, I think. The intent with the xfree86
mode type was that "built-in" modes were known quantities of the
hardware, either because the hardware only had one mode or due to
strapping pins or the like. These should be considered "supplied by the
driver" as with EDID-derived modes.
With or without that, patches 2 3 4 and 8 are:
Reviewed-by: Adam Jackson <ajax@xxxxxxxxxx>
- ajax
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
