On Tue, Jan 24, 2012 at 09:04, Daniel Vetter <daniel at ffwll.ch> wrote: > On Tue, Jan 24, 2012 at 10:35:04AM +0000, Chris Wilson wrote: > > On Tue, 24 Jan 2012 09:44:28 +0100, Daniel Vetter < > daniel.vetter at ffwll.ch> wrote: > > > We need this to correctly access registers in the gt power well from > > > userspace. > > > > How about a INTEL_INFO(dev)->has_forcewake or check for the > > ->forcewake_get? That would be more self-documenting, and we are less > > likely to miss one in the future, than adding more random generation > > checks. > > I'll jot down a todo to create a cleanup patch for -next that introduce > some feature flags like has_forcewake has_rc6 and such to avoid such > gaffles (hopefully). > I actually wrote about the very same idea in my previous email :). So +1 to that! -- Eugeni Dodonov <http://eugeni.dodonov.net/> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120124/77e1a80c/attachment-0001.htm>
