On Tue, Jan 24, 2012 at 10:35:04AM +0000, Chris Wilson wrote: > On Tue, 24 Jan 2012 09:44:28 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > > We need this to correctly access registers in the gt power well from > > userspace. > > How about a INTEL_INFO(dev)->has_forcewake or check for the > ->forcewake_get? That would be more self-documenting, and we are less > likely to miss one in the future, than adding more random generation > checks. I'll jot down a todo to create a cleanup patch for -next that introduce some feature flags like has_forcewake has_rc6 and such to avoid such gaffles (hopefully). -Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
