On Thu, Nov 09, 2017 at 03:08:18AM +0000, Pandiyan, Dhinakaran wrote: > > > > On Wed, 2017-11-01 at 11:55 +0200, Jani Nikula wrote: > > On Tue, 31 Oct 2017, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > > > The main attraction of this series is removal of > > > intel_digital_port->port. Ever since the introduction of > > > intel_encoder->port it has been redundant, and I figured > > > it's high time we kill it. > > > > > > The other stuff is mostly elimination of uses of the > > > legacy encoder->crtc pointer and intel_crtc->config. While those > > > do still work we do kinda want to kill them off, and instead use > > > the proper atomic states instead. Having multiple ways to do things > > > also tends to confuse people so the sooner we get this cleaned utp > > > the better. I think I mostly got the the encoder side done now, > > > apart from link training related code which will need more thought. > > > > For starters, on the series, > > > > Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > > > I glanced through everything but I can't say I reviewed it yet. > > > > BR, > > Jani. > > > > Only nits in a couple of places, you can address them if you want to. > Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx> for the > series. Series pushed to dinq. Thanks for the review. > > > > > > > Entire series available here: > > > git://github.com/vsyrjala/linux.git nuke_dig_port_port_4 > > > > > > Ville Syrjälä (10): > > > drm/i915: Eliminate some encoder->crtc usage from DP code > > > drm/i915: Eliminate some encoder->crtc usage from DSI code > > > drm/i915: Eliminate some encoder->crtc usage from SDVO code > > > drm/i915: Eliminate some encoder->crtc usage from TV code > > > drm/i915: Pass crtc state to DPIO PHY functions > > > drm/i915: Eliminate crtc->config usage from CRT code > > > drm/i915: Replace dig_port->port with encoder port for BXT DPLL > > > selection > > > drm/i915: Nuke intel_digital_port->port > > > drm/i915: Clean up PPS code calling conventions > > > drm/i915: Clean up DP code local variables and calling conventions > > > > > > drivers/gpu/drm/i915/i915_debugfs.c | 2 +- > > > drivers/gpu/drm/i915/i915_drv.h | 19 +- > > > drivers/gpu/drm/i915/intel_crt.c | 44 ++-- > > > drivers/gpu/drm/i915/intel_ddi.c | 13 +- > > > drivers/gpu/drm/i915/intel_display.c | 13 +- > > > drivers/gpu/drm/i915/intel_dp.c | 432 +++++++++++++++------------------- > > > drivers/gpu/drm/i915/intel_dp_mst.c | 6 +- > > > drivers/gpu/drm/i915/intel_dpio_phy.c | 99 ++++---- > > > drivers/gpu/drm/i915/intel_dpll_mgr.c | 10 +- > > > drivers/gpu/drm/i915/intel_drv.h | 5 +- > > > drivers/gpu/drm/i915/intel_dsi.c | 17 +- > > > drivers/gpu/drm/i915/intel_hdmi.c | 34 ++- > > > drivers/gpu/drm/i915/intel_pipe_crc.c | 4 +- > > > drivers/gpu/drm/i915/intel_psr.c | 4 +- > > > drivers/gpu/drm/i915/intel_sdvo.c | 4 +- > > > drivers/gpu/drm/i915/intel_tv.c | 4 +- > > > 16 files changed, 316 insertions(+), 394 deletions(-) > > -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
