>From gen10 onwards 16bpp 90/270 plane rotation is supported on hardware. Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@xxxxxxxxx> Testcase: https://patchwork.freedesktop.org/patch/186179/ --- drivers/gpu/drm/i915/intel_atomic_plane.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_atomic_plane.c b/drivers/gpu/drm/i915/intel_atomic_plane.c index ffd36fb..d321e31 100644 --- a/drivers/gpu/drm/i915/intel_atomic_plane.c +++ b/drivers/gpu/drm/i915/intel_atomic_plane.c @@ -123,14 +123,17 @@ static bool intel_valid_rotation(const struct drm_plane_state *plane_state) } /* - * 90/270 is not allowed with RGB64 16:16:16:16, - * RGB 16-bit 5:6:5, and Indexed 8-bit. + * 90/270 is not allowed with RGB64 16:16:16:16 and + * Indexed 8-bit. RGB 16-bit. 5:6:5 is allowed gen10 onwards. * TBD: Add RGB64 case once its added in supported format * list. */ switch (plane_state->fb->format->format) { - case DRM_FORMAT_C8: case DRM_FORMAT_RGB565: + if (INTEL_GEN(dev_priv) >= 10) + break; + /* fall through */ + case DRM_FORMAT_C8: DRM_DEBUG_KMS( "Unsupported pixel format %s for 90/270!\n", drm_get_format_name( -- 2.7.4 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
