Re: [PATCH] drm/i915: Simplify onion for bxt_ddi_phy_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes:

> Older compilers (gcc-4.9) are not as able to track uninitialised
> variables as well as more recent compilers. In particular,
>
> drivers/gpu/drm/i915/intel_dpio_phy.c: In function ‘bxt_ddi_phy_init’:
> drivers/gpu/drm/i915/intel_dpio_phy.c:482:25: warning: ‘was_enabled’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> In this case, we can rearrange code slightly to make the control flow
> clearer to the reader, as well as the compiler. That is we only call
> uninit using the same predicate as calling init
>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@xxxxxxxxx>
> Cc: Imre Deak <imre.deak@xxxxxxxxx>


Reviewed-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxxxx>

-- 
Gabriel Krisman Bertazi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux