On 7 November 2017 at 15:40, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue > drivers/gpu/drm/i915/i915_cmd_parser.c:811:23: error: not an lvalue > drivers/gpu/drm/i915/i915_cmd_parser.c:814:23: error: not an lvalue > drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue > drivers/gpu/drm/i915/i915_cmd_parser.c:811:23: error: not an lvalue > drivers/gpu/drm/i915/i915_cmd_parser.c:814:23: error: not an lvalue > drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue > drivers/gpu/drm/i915/i915_cmd_parser.c:811:23: error: not an lvalue > drivers/gpu/drm/i915/i915_cmd_parser.c:814:23: error: not an lvalue > drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue > drivers/gpu/drm/i915/i915_cmd_parser.c:811:23: error: not an lvalue > drivers/gpu/drm/i915/i915_cmd_parser.c:814:23: error: not an lvalue > > If we move the shift into each case not only do we kill the warning from > smatch, but we shrink the code slightly: > > text data bss dec hex filename > 1267906 20587 3168 1291661 13b58d before > 1267890 20587 3168 1291645 13b57d after > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx> > Cc: Matthew Auld <matthew.william.auld@xxxxxxxxx> Reviewed-by: Matthew Auld <matthew.william.auld@xxxxxxxxx> _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
