On Mon, 06 Nov 2017 10:05:34 +0100 Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote: > Hi, > > > > I thought we had agreed to make this behave similar to > > > VFIO_GROUP_GET_DEVICE_FD, the ioctl would take a __u32 dmabuf_id > > > and > > > return the file descriptor as the ioctl return value. Thanks, > > > > If we follow VFIO_GROUP_GET_DEVICE_FD, we would lose flags > > functionality. > > Zhi and Zhenyu, how do you think about it? > > The ioctl is simple enough that not having flags should not be a > problem I think. > > Also note that dmabuf_id is received using the PLANE_INFO ioctl, so > should the need arise to negotiate something in the future chances are > high that it can be done using the PLANE_INFO ioctl flags. Right, the ioctl is "get fd for thing" so we have control of "thing". I think we had this same discussion on v15. Thanks, Alex _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx