Re: [PATCH 05/20] drm/i915: Save all GT WAs and apply them at a later time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/31/2017 07:14 AM, Joonas Lahtinen wrote:
On Mon, 2017-10-30 at 13:17 -0700, Oscar Mateo wrote:
By doing this, we can dump these workarounds in debugfs for validation (which,
at the moment, we are only able to do for the contexts WAs).

v2:
   - Wrong macro used for MMIO set bit masked
   - Improved naming
   - Rebased

v3:
   - GT instead of MMIO (Chris, Mika)
   - Leave L3_PRIO_CREDITS_MASK for a separate patch
   - Rebased

v4: Carry the init_early nomenclature over (Chris)

Signed-off-by: Oscar Mateo <oscar.mateo@xxxxxxxxx>
Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
This and the following patch are still a no-go and won't be merged. The
required changes for the series to be accepted (to make it more
declarative) were clearly described previously. If there are further
questions, we should discuss those instead wasting time looking at
respins that do not address the input given.

Respins that ignore review are a waste of everyone's time. So, please
react to the review instead of trying to brute force a series in as you
see fit.

Regards, Joonas

My apologies, I wasn't trying to "brute force" anything. I haven't been able to work on this for the last two weeks and I didn't want the issue to go cold, so I sent a version to attend to Ville's and Chris' review comments (this is useful anyway, because the same comments apply whether you go with functions or with a static table). I am working on a version that implements your suggestions and I will send it as soon as it's ready.

-- Oscar

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux