Re: [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2017-10-30 at 17:29 +0000, Chris Wilson wrote:
> To quote kbuild/makefiles.txt:
> 
>     cc-disable-warning checks if gcc supports a given warning and returns
>     the commandline switch to disable it. This special function is needed,
>     because gcc 4.4 and later accept any unknown -Wno-* option and only
>     warn about it if there is another warning in the source file.
> 
> This is exactly what we were trying to achieve with cc-option -Wno-foo and
> failed miserably.
> 
> Reported-by: kbuild-all@xxxxxx
> Fixes: 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set warnings to full")
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> Cc: Jani Nikula <jani.nikula@xxxxxxxxx>

Poor person who greps for "-Wno-", should we add comment
"# -Wno-whatever" at the end of each line?

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux