We've been supporting reset-engine in execlist submission mode for a while, but with GuC, the resubmission path had to be different because we used to re-enable the engines before GuC... so we've been using full gpu reset when GuC submission is enabled (which reset the fw). Thanks to Michal Winiarski GuC preemption changes, the firmware is now enabled before restarting the engines, so the replay part after resetting an engine is no longer different. The only change now is that the reset-engine is requested to the firmware via a H2G command, and GuC is the one in charge of acquiring the forcewake and idling the engine before reseting it. (The first patch is a cosmetic change, which I'm sure Tvrtko doesn't remember he reviewed [1]). [1] https://lists.freedesktop.org/archives/intel-gfx/2017-April/126813.html Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx> Michal Wajdeczko (1): HAX enable GuC submission for CI Michel Thierry (2): drm/i915/guc: Rename the function that resets the GuC drm/i915/guc: Add support for reset engine using GuC commands drivers/gpu/drm/i915/i915_drv.c | 9 +++++++-- drivers/gpu/drm/i915/i915_drv.h | 3 ++- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++------ drivers/gpu/drm/i915/i915_params.h | 4 ++-- drivers/gpu/drm/i915/intel_guc.c | 24 ++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_guc_fwif.h | 1 + drivers/gpu/drm/i915/intel_uc.c | 4 ++-- drivers/gpu/drm/i915/intel_uncore.c | 7 +------ 8 files changed, 41 insertions(+), 19 deletions(-) -- 2.14.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
