Re: [PATCH 1/2] drm/i915: Add is-wedged flag to intel_engine_dump()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes:

> Comparing the state tested by intel_engine_is_idle() and printed by
> intel_engine_dump(), the only bit not shown is whether or not the device
> is wedged. Add that little bit of information to the pretty printer so
> that if the engine fails to idle we can see why.
>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>

Reviewed-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>

> ---
>  drivers/gpu/drm/i915/intel_engine_cs.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index 6895a90af008..a8ea27bea171 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -1693,7 +1693,9 @@ void intel_engine_dump(struct intel_engine_cs *engine, struct drm_printer *m)
>  	struct rb_node *rb;
>  	u64 addr;
>  
> -	drm_printf(m, "%s\n", engine->name);
> +	drm_printf(m, "%s%s\n", engine->name,
> +		   i915_terminally_wedged(&engine->i915->gpu_error) ?
> +		   " (wedged)" : "");
>  	drm_printf(m, "\tcurrent seqno %x, last %x, hangcheck %x [%d ms], inflight %d\n",
>  		   intel_engine_get_seqno(engine),
>  		   intel_engine_last_submit(engine),
> -- 
> 2.15.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux