Re: [PATCH] drm/i915: Mention which driver is taking over the VGA console

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 27/10/2017 22:33, Chris Wilson wrote:
Currently there is a rather bland,

[    4.987589] [drm] Replacing VGA console driver

I had some patches which replaced this with [i915], but then Robert Bragg had some even better patches to improve the DRM logging in general. It might be best to resurrect those rather than use different logging APIs throughput the code depending on the desired output?

Regards,

Tvrtko

for when we take over the console. Let's put a (device) name on that.
If we opt for DRM_DEV_INFO we get

[    5.071879] i915 0000:00:02.0: [drm:i915_kick_out_vgacon] Replacing VGA console driver

which is a little ugly side for a user message. So just use a plain
dev_info() instead:

[    4.948501] i915 0000:00:02.0: Replacing VGA console driver

Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
---
  drivers/gpu/drm/i915/i915_drv.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index af745749509c..c194dfa11125 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -751,7 +751,7 @@ static int i915_kick_out_vgacon(struct drm_i915_private *dev_priv)
  {
  	int ret = 0;
- DRM_INFO("Replacing VGA console driver\n");
+	dev_info(dev_priv->drm.dev, "Replacing VGA console driver\n");
console_lock();
  	if (con_is_bound(&vga_con))

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux