Quoting Jani Nikula (2017-10-26 15:36:34) > On Tue, 24 Oct 2017, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > > Recently W=1 on gcc-7.2 (-Wunused-const-variable) caught a regression > > that had been lurking for 6 months, so lets try enabling the full set of > > warnings for CI builds. This means more patches will be rejected early > > that contain trivial and sometimes not so trivial bugs. However, our > > code does not yet compile cleanly with W=1, so we have to apply a filter > > to the set of warnings until we can eliminate the mistakes. It also > > means that developers will have to be running the full gamut of gcc to > > ensure that as warnings come and go with gcc updates, we have the CI > > build prepared. > > > > v2: Use fine-grained -Wno overrides. Inside the makefile, we can > > specify CFLAGS on a per-object level, which allows us to limit the scope > > of any particular warning override. > > v3: Place per-file overrides after the main enabling block. > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > > Cc: Jani Nikula <jani.nikula@xxxxxxxxx> > > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> > > Cc: Tomi Sarvela <tomi.p.sarvela@xxxxxxxxx> > > Cc: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Acked-by: Tomi Sarvela <tomi.p.sarvela@xxxxxxxxx> > > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > > --- > > Seeking more acks for making our lives harder by giving gcc free reign > > in its warnings. > > Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx> So be it. I hope I don't regret letting gcc rule over us! -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
