Quoting Michał Winiarski (2017-10-25 11:34:27) > On Fri, Oct 20, 2017 at 11:24:19AM +0100, Chris Wilson wrote: > > __gem_create() doesn't touch the outparam *handle on failure, so we can > > no longer assert that it zero. This is reasonable to remove as it is just > > testing the library itself and not the kernel, so no loss in coverage. > > We already had to remove the false assertion that gem_create() must fail > > following fd exhaustion (as we can not prevent the kernel from freeing > > VFS fdspace in between calls). > > > > The last remaining change is that we do no need to rely on an external > > path for open() as dup() will do the job of exhausting the fdtable. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103365 > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Reviewed-by: Michał Winiarski <michal.winiarski@xxxxxxxxx> > > But do we really need this test? Perhaps we could just remove it? It's not a vital test, it runs up against a kernel limit that we can't really check. It's the type of thing one would use to seed kcov-afl as a hint towards the different boundary cases. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
