Re: [PATCH v2] drm/i915/selftests: Don't try to queue a request with zero delay

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Chris Wilson (2017-10-25 11:06:01)
> Instead of trying to create a timer with zero delay (i.e. with expires
> set to the current jiffies and not the future, an already expired
> timer), execute that request immediately.
> 
> v2: Refactor list_del_init+signal into its own little function.
> 
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Link: https://patchwork.freedesktop.org/patch/msgid/20171024220855.30155-1-chris@xxxxxxxxxxxxxxxxxx
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>

Scratch that, the refactor was nice, because it made 
> -       request = first_request(engine);
> -       if (request) {
> -               list_del_init(&request->link);
> -               mock_seqno_advance(&engine->base, request->base.global_seqno);
> +       while ((request = first_request(engine))) {
> +               advance(engine, request);
> +               if (request->delay)
> +                       break;

this stand out as bogus.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux