On Thu, 19 Oct 2017 15:30:44 +0200, Chris Wilson
<chris@xxxxxxxxxxxxxxxxxx> wrote:
Quoting Michal Wajdeczko (2017-10-19 13:57:06)
@@ -774,6 +793,11 @@ int i915_error_state_to_str(struct
drm_i915_error_state_buf *m,
err_print_capabilities(m, &error->device_info);
err_print_params(m, &error->params);
+ if (HAS_GUC(dev_priv)) {
Could we not peek inside the struct to know if it has been set? Looking
at the current device should be a last resort -- better to assume that
everything and anything may have been overwritten since the error.
I was following earlier patterns where HAS_CSR/IS_GEN were used.
Will change into:
if (error->device_info.has_guc) {
+ intel_uc_fw_dump(&dev_priv->guc.fw, &p);
+ intel_uc_fw_dump(&dev_priv->huc.fw, &p);
+ }
Ooops, I don't know how it happen but above dump should be:
intel_uc_fw_dump(&error->guc_fw, &p);
intel_uc_fw_dump(&error->huc_fw, &p);
Michal
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
