On Tue, 2017-10-17 at 15:50 -0700, Sujaritha Sundaresan wrote: > We currently have two module parameters that control GuC: > "enable_guc_loading" and "enable_guc_submission". Whenever > we need i915_modparams.enable_guc_submission=1, we also need > enable_guc_loading=1. We also need enable_guc_loading=1 when > we want to verify the HuC, which is every time we have a HuC > (but all platforms with HuC have a GuC and viceversa). I already gave comments about clarifying the commit message, that does not seem to have been addressed. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx