Quoting Michal Wajdeczko (2017-10-17 10:44:49) > Debugfs for GuC and HuC load info have similar common part. > Move and update dump of uc_fw to separate helper for reuse. > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> The other place where this information is interesting is in i915_gpu_error.c Can we take a copy of struct intel_uc_fw for huc/guc and pretty print it? Would require us to expose some methods for drm_printer to redirect it back to the error_state_buf. On paper it seems feasible. In the back of my mind, I would like to get similar reuse for intel_engine_dump and error-state. That seems a bit trickier as we have to make copies of more things (whereas here we just take a shallow copy of the struct uc_fw). -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
