Re: [PATCH v4 11/14] drm/i915: Update DMC firmware load error messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Michal Wajdeczko (2017-10-13 12:11:34)
> Some of the error messages from DMC load were too generic and
> may be confusing for the user. Lets explicitly add DMC words there.
> Also as homepage of DMC firmware is same as for the GuC and Huc,
> lets reuse URL definition.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Imre Deak <imre.deak@xxxxxxxxx>
> Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxx>

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

I also agree that those DRM_ERROR should be DRM_WARN as you did you for
the other fw loading. They aren't fatal to the driver, but something is
wrong in the external fw.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux