On Tue, 10 Oct 2017, "Sharma, Shashank" <shashank.sharma@xxxxxxxxx> wrote: > Regards > > Shashank > > > On 10/10/2017 3:42 PM, Saarinen, Jani wrote: >> Hi, >> >>> -----Original Message----- >>> From: Intel-gfx [mailto:intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx] On Behalf >>> Of Shashank Sharma >>> Sent: tiistai 10. lokakuuta 2017 13.08 >>> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx >>> Subject: [PATCH v3 0/3] Various retries for LSPCON >>> >>> This patch series adds various retries and delays in DRM and I915 layer, to >>> handle some of the read failures while dealing with LSPCON devices. >> Should we have reference to fdo bugs? >> https://bugs.freedesktop.org/show_bug.cgi?id=102294 >> https://bugs.freedesktop.org/show_bug.cgi?id=102295 > Yes, sure seems like a good idea. >> and what about this? >> https://bugs.freedesktop.org/show_bug.cgi?id=102359 > This seems like one probable candidate :) Pushed the series, thanks for the patches and review. Added a bunch of likely Bugzilla links to all commits, didn't bother with mapping commits and bugs. Probably the whole series is needed for most of them anyway. BR, Jani. > > - Shashank >>> LSPCON devices are sometimes slow to respond and the vendores expect us >>> to retry while probing the device. >>> >>> The typical scenarios are getting fixed / handled with this patch series are >>> look like this failure during LSPCON >>> suspend/resume: >>> [drm:drm_lspcon_get_mode] *ERROR* LSPCON read(0x80, 0x41) failed >>> [drm:lspcon_wait_mode [i915]] *ERROR* Error reading LSPCON mode >>> [drm:drm_lspcon_get_mode] *ERROR* LSPCON read(0x80, 0x41) failed >>> [drm:lspcon_change_mode.constprop.4 [i915]] *ERROR* Error reading >>> LSPCON mode [drm:lspcon_resume [i915]] *ERROR* LSPCON resume failed >>> Setting dangerous option reset - tainting kernel >>> >>> Shashank Sharma (3): >>> drm: Add retries for lspcon mode detection >>> drm/i915: Don't give up waiting on INVALID_MODE >>> drm/i915: Add retries for LSPCON detection >>> >>> drivers/gpu/drm/drm_dp_dual_mode_helper.c | 16 +++++++++++++--- >>> drivers/gpu/drm/i915/intel_lspcon.c | 22 +++++++++++++++------- >>> 2 files changed, 28 insertions(+), 10 deletions(-) >>> >>> -- >>> 2.7.4 >> >> Jani Saarinen >> Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo >> >> > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx