On Mon, Jan 09, 2012 at 12:42:06PM -0200, Eugeni Dodonov wrote: > On Mon, Jan 9, 2012 at 12:03, <przanoni at gmail.com> wrote: > > > From: Paulo Zanoni <paulo.r.zanoni at intel.com> > > > > This is a command-line tool that allows us to display and modify the > > InfoFrames we send. > > > > Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com> > > > > Very interesting! > > I think that it would be more interesting to use command line options > instead of interactive input - something like: > -d, --dump > -c, --change [parameters] > -dd, --dip-disable > -de, --dip-enable [parameters] > -hd, --hdmi-disable > -he, --hdmi-enable [parameters] > > So this could be scripted and used non-interactively. This would also > simplify your change_avi_infoframe and parse_infoframe_option_s - you could > just pass all the values as parameters instead. I like Eugeni's suggestion - all our other dump/decode/fiddle with the hw tools are non-interactive (safe only for intel_gpu_top iirc). Can I bother you to do this? Yours, Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
