On Mon, Jan 9, 2012 at 12:03, <przanoni at gmail.com> wrote: > From: Paulo Zanoni <paulo.r.zanoni at intel.com> > > This is a command-line tool that allows us to display and modify the > InfoFrames we send. > > Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com> > Very interesting! I think that it would be more interesting to use command line options instead of interactive input - something like: -d, --dump -c, --change [parameters] -dd, --dip-disable -de, --dip-enable [parameters] -hd, --hdmi-disable -he, --hdmi-enable [parameters] So this could be scripted and used non-interactively. This would also simplify your change_avi_infoframe and parse_infoframe_option_s - you could just pass all the values as parameters instead. Other than that, Reviewed-by: Eugeni Dodonov <eugeni.dodonov at intel.com> -- Eugeni Dodonov <http://eugeni.dodonov.net/> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120109/9af213ac/attachment.htm>
