On Thu, 12 Oct 2017 10:51:58 +0200, Chris Wilson
<chris@xxxxxxxxxxxxxxxxxx> wrote:
Quoting Michal Wajdeczko (2017-10-10 15:51:26)
We want to keep ucode xfer functions separate from other
initialization. Once separated, add explicit forcewake.
Suggested-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>
Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Cc: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx>
---
drivers/gpu/drm/i915/intel_guc.c | 88
+++++++++++++++++++++++++++++++++
drivers/gpu/drm/i915/intel_guc.h | 1 +
drivers/gpu/drm/i915/intel_guc_loader.c | 85
-------------------------------
drivers/gpu/drm/i915/intel_uc.c | 1 +
4 files changed, 90 insertions(+), 85 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_guc.c
<snip>
+
+ for (i = 0; i < GUC_CTL_MAX_DWORDS; i++)
for (i = 1; i <= MAX; i++) ?
+ I915_WRITE(SOFT_SCRATCH(1 + i), params[i]);
Not so sure, as this loop is over CTL params[] not SCRATCH() regs.
Michal
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
