On Mon, 09 Oct 2017, Thierry Reding <treding@xxxxxxxxxx> wrote:
> On Mon, Oct 09, 2017 at 12:29:57PM +0300, Jani Nikula wrote:
>> Falling back to the lowest value is likely the only thing we can do, but
>> doing it silently seems like a bad thing to do. Catch it early and make
>> loud noises.
>>
>> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
>> Cc: Thierry Reding <treding@xxxxxxxxxx>
>> Cc: Rob Clark <robdclark@xxxxxxxxx>
>> Cc: Sean Paul <seanpaul@xxxxxxxxxxxx>
>> Cc: Manasi Navare <manasi.d.navare@xxxxxxxxx>
>> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
>> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>> ---
>> drivers/gpu/drm/drm_dp_helper.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
>> index 08af8d6b844b..dca21b5a03ec 100644
>> --- a/drivers/gpu/drm/drm_dp_helper.c
>> +++ b/drivers/gpu/drm/drm_dp_helper.c
>> @@ -137,8 +137,10 @@ EXPORT_SYMBOL(drm_dp_link_train_channel_eq_delay);
>> u8 drm_dp_link_rate_to_bw_code(int link_rate)
>> {
>> switch (link_rate) {
>> - case 162000:
>> default:
>> + WARN(1, "unknown DP link rate %d, using %x\n", link_rate,
>> + DP_LINK_BW_1_62);
>> + case 162000:
>> return DP_LINK_BW_1_62;
>> case 270000:
>> return DP_LINK_BW_2_7;
>> @@ -151,8 +153,9 @@ EXPORT_SYMBOL(drm_dp_link_rate_to_bw_code);
>> int drm_dp_bw_code_to_link_rate(u8 link_bw)
>> {
>> switch (link_bw) {
>> - case DP_LINK_BW_1_62:
>> default:
>> + WARN(1, "unknown DP link bw code %x, using 162000\n", link_bw);
>
> Nit: "DP link BW" because it is an abbreviation. Otherwise looks good:
Thanks for the reviews everyone, pushed patch 1 with BW upcased to
drm-misc-next.
BR,
Jani.
>
> Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
