On 10/09/2017 02:06 PM, Chris Wilson wrote:
Quoting Oscar Mateo (2017-10-09 21:58:17)
This has grown to be a sizable amount of code, so move it to
its own file before we try to refactor anything. For the moment,
we are leaving behind the WA BB code and the WAs that get applied
(incorrectly) in init_clock_gating, but we will deal with it later.
Signed-off-by: Oscar Mateo <oscar.mateo@xxxxxxxxx>
Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/i915_workarounds.c | 705 ++++++++++++++++++++++++++++++++
drivers/gpu/drm/i915/i915_workarounds.h | 31 ++
If we look at the filenames with rose-tinted glasses:
intel_* -> interaction with hw
i915_* -> interaction with user
(Let's not start on the mixup entailed when we use the i915 prefix to
mean to talking to gen2/gen3. Hopefully most gen2 mixups are history.)
i915_workarounds would imply w/a for the drm/i915 uABI, but we want
intel_workarounds to imply w/a for hw.
Now some are indeed workarounds to keep uABI constant (or otherwise
correct)... The line can be murky ;)
-Chris
I remembered file prefixes had a meaning, but I tried to recall it from
memory and came up with the exact opposite (and I looked at
i915_guc_submission.c as proof that I was recalling it correctly :P).
I'll rename the files, no problem.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
