On Mon, 2017-10-09 at 12:00 +0100, Matthew Auld wrote: > It's a little unclear what the sg_mask actually is, so prefer the more > meaningful name of sg_page_sizes. > > Suggested-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Signed-off-by: Matthew Auld <matthew.auld@xxxxxxxxx> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> <SNIP> > @@ -2489,16 +2489,16 @@ void __i915_gem_object_set_pages(struct drm_i915_gem_object *obj, > obj->mm.quirked = true; > } > > - GEM_BUG_ON(!sg_mask); > - obj->mm.page_sizes.phys = sg_mask; > + GEM_BUG_ON(!sg_page_sizes); > + obj->mm.page_sizes.phys = sg_page_sizes; > > /* > - * Calculate the supported page-sizes which fit into the given sg_mask. > - * This will give us the page-sizes which we may be able to use > - * opportunistically when later inserting into the GTT. For example if > - * phys=2G, then in theory we should be able to use 1G, 2M, 64K or 4K > - * pages, although in practice this will depend on a number of other > - * factors. > + * Calculate the supported page-sizes which fit into the given > + * sg_page_sizes. This will give us the page-sizes which we may be able Double space before "This". Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
