Quoting Maarten Lankhorst (2017-10-09 10:41:29) > Op 06-10-17 om 19:18 schreef Chris Wilson: > > When we unregister the connector, we may have a pending hotplug work. > > This needs to be cancel early during the teardown so that it does not > > fire after we have freed the connector. Or else we may see something like: > Well the nice thing is even if it's called modeset_retry_work, it just sets the link status to bad for DP. Ok, and sends a hotplug event. At what point in the shutdown sequence does that drm_kms_helper_hotplug_event() become invalid? > I worry it might be too early, wouldn't intel_dp_connector_destroy be a better place? At that point we know userspace can no longer use it, > because the last reference has been removed. connector_destroy is after drm_kms_helper_poll_fini(), so that seems suspect given a query about drm_kms_helper_hotplug_event() A hook from drm_atomic_helper_shutdown? Extending unregister to have a late phase? -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
