On Sat, 2017-10-07 at 09:56 +0100, Chris Wilson wrote:
> Engines are now only allocated during init_mmio, so we can forgo
> iterating over the empty list and calling kfree(NULL) prior to
> intel_engines_init_mmio().
>
> Fixes: 63ffbcdadcf2 ("drm/i915: Sanitize engine context sizes")
This use of the tag would be correct according to "Fixes:" part of:
https://www.kernel.org/doc/html/v4.13/process/submitting-patches.html#r
eviewer-s-statement-of-oversight
But it definitely says "bug" in there, so the other more stylistic
issues "Impact: None", indeed should not get a Fixes: tag.
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
