Re: [PATCH v2 06/11] drm/i915: Name i915_runtime_pm structure in dev_priv as "rpm"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/6/2017 6:10 PM, Chris Wilson wrote:
Quoting Sagar Arun Kamble (2017-10-06 13:13:35)
We were using dev_priv->pm for runtime power management related state.
This patch renames it to "rpm" which looks more apt. Will be using pm
for state containing RPS/RC6 state in the next patch.

Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx>
Cc: Imre Deak <imre.deak@xxxxxxxxx>
Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Reviewed-by: Radoslaw Szwichtenberg <radoslaw.szwichtenberg@xxxxxxxxx>
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Thinking about this again, rpm, pm are very close. How about if we used
i915->runtime_pm and i915->gt_pm (or i915->gt.pm)? Imre, any thoughts?
rps.hw_lock/pcu_lock is used by display too, so I just kept it pm. should we pull rps.hw_lock/pcu_lock out into drm_i915_private
and then gt_pm would be good.
-Chris

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux