Re: [PATCH 08/10] drm/i915: Create generic function to setup ring frequency table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Sagar Arun Kamble (2017-10-04 15:07:23)
> Prepared intel_update_ring_freq function to setup ring frequency
> for applicable platforms determined by macro - NEEDS_RING_FREQ_UPDATE
> 
> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx>
> Cc: Imre Deak <imre.deak@xxxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenberg@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 19 +++++++++++++++----
>  1 file changed, 15 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 1ccc3fb..62aed72 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -7868,6 +7868,19 @@ static void intel_init_emon(struct drm_i915_private *dev_priv)
>         dev_priv->ips.corr = (lcfuse & LCFUSE_HIV_MASK);
>  }
>  
> +#define NEEDS_RING_FREQ_UPDATE(i915) \
> +          (((INTEL_GEN(i915) >= 9) && \
> +            (IS_GEN9_BC(i915) || IS_CANNONLAKE(i915))) || \
> +           (IS_BROADWELL(i915)) || \
> +           ((INTEL_GEN(i915) >= 6) && \
> +            (!IS_CHERRYVIEW(i915) && !IS_VALLEYVIEW(i915))))

Let's not contort ourselves into using a macro where gcc will compile a
function just as tightly.

Compare modifying a more verbose function than this macro for the next
BC/LP.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux