Re: [PATCH v3 4/9] drm/i915/uc: Move uC fw helper code into dedicated files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 04 Oct 2017 16:23:50 +0200, Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> wrote:

On Tue, 2017-10-03 at 16:36 +0000, Michal Wajdeczko wrote:
This is a prerequisite to unblock next steps.

v2: correct include order (Joonas)

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>
Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx>
Reviewed-by: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx>

s/i915_fetch_uc_fw/intel_uc_fw_init/

Actually, "fetch_uc" function is not symmetrical to "fw_init" so
above rename will be misleading. I'm planning to add below init
function after we are done with all moves:

intel_uc_fw_init(struct intel_uc_fw *fw, enum intel_uc_fw_type type);

Given above, can I still keep your r-b?

Michal


And this is;

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>

Can you then re-submit these first four patches for CI results and I'll
merge them.

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux