Re: [PATCH 17/21] drm/i915/selftests: huge page tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Matthew Auld (2017-09-29 17:10:28)
> +static unsigned int get_largest_page_size(struct drm_i915_private *i915,
> +                                         size_t rem)

Grr, I dislike size_t in the kernel. It's not tied to the physical
address size, or virtual address size (or either dma or ourselves).
In most cases you really do mean unsigned long, but often there's an
explicit type you could use. Note that they need u64 math protection (or
at least using the macros for handling longs).
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux