On Mon, Oct 02, 2017 at 04:00:12PM -0700, Daniele Ceraolo Spurio wrote: > The tests were merged before the feature, which never made it to the > driver; the last update I could find ([1]) is more than a year old. > The tests are using a wrong getparam number and planned extensions > to the gem_create and get_aperture ioctl structures that don't match > what's currently in i915. Due to this all stolen-related subtests are > skipping. > Given the fact that there has been no traction behind the feature for > a long time it doesn't look like we'll need those tests anytime soon > and thus it makes sense to remove them. > > The patches didn't revert cleanly and also contained some improvements > that are worth keeping, so instead of a revert I've organized the removal > in a single patch per test file to drop only the unneeded code. > > [1] https://patchwork.freedesktop.org/series/659/ > > Cc: Ankitprasad Sharma <ankitprasad.r.sharma@xxxxxxxxx> > Cc: Petri Latvala <petri.latvala@xxxxxxxxx> > Cc: Arkadiusz Hiler <arkadiusz.hiler@xxxxxxxxx> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Ack from my side on the entire series. Merging stuff before the kernel side has landed is a good way to piss of Dave Airlie. Yes CI right now doesn't support testing both a kernel and an igt branch at the same time, so not that useful for testing new features. It's on the list, but then CI is primarily about preventing regressions, not so much about making sure new stuff works perfectly out of the box (would be good too ofc). -Daniel > > Daniele Ceraolo Spurio (6): > tests/gem_pread: drop stolen memory related subtests > tests/gem_pwrite: drop stolen memory related subtests > tests/gem_create: drop stolen memory related subtest > tests/gem_stolen: drop gem_stolen.c > tests/gem_concurrent_all: drop stolen memory related subtests > lib/ioctl_wrappers: drop stolen memory related wrappers > > lib/ioctl_wrappers.c | 119 ------------ > lib/ioctl_wrappers.h | 16 -- > tests/Makefile.sources | 1 - > tests/gem_concurrent_all.c | 35 ---- > tests/gem_create.c | 37 +--- > tests/gem_pread.c | 95 ---------- > tests/gem_pwrite.c | 43 ----- > tests/gem_stolen.c | 455 --------------------------------------------- > 8 files changed, 2 insertions(+), 799 deletions(-) > delete mode 100644 tests/gem_stolen.c > > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
