On Tue, 2017-10-03 at 11:28 +0530, Sagar Arun Kamble wrote: > > On 10/2/2017 7:31 PM, Michal Wajdeczko wrote: > > From: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx> > > > > This patch adds new function intel_uc_init_mmio which will initialize > > MMIO access related variables prior to uc load/init. > > > > v2: Removed unnecessary export of guc_send_init_regs. Created > > intel_uc_init_mmio that currently wraps guc_init_send_regs. (Michal) > > > > Cc: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > > Cc: Michał Winiarski <michal.winiarski@xxxxxxxxx> > > Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx> > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > > Looks good to me. > Acked-by: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx> Acking code written (even partially) by you would not be the thing to do :) https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html#when-to-use-acked-by-and-cc It has your "From:" and S-o-b, so that should be enough, the chronological order here should be; From: Sagar ... v2 (Michal): ... S-o-b: Sagar Cc: Michal Cc: Michał S-o-b: Michal This would show that Sagar originally wrote the patch, and Michael has made further modifications to the original. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
