On Fri, 2017-09-22 at 16:11 +0100, Lionel Landwerlin wrote: > Verifies that the kernel programs slices correctly based by reading > the value of PWR_CLK_STATE register. > > v2: Add subslice tests (Lionel) > Use MI_SET_PREDICATE for further verification when available (Lionel) > > Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx> > --- > tests/Makefile.sources | 1 + > tests/ctx_rpcs.c | 453 +++++++++++++++++++++++++++++++++++++++++++++++++ This should definitely be 'gem_ctx_rpcs' :) Unless I missed it, this test only checks that the registers are written to and get read. It doesn't functionally validate that the hardware actually performs differently based on what you set? Maybe under benchmarks/ it would be appropriate to compare the effect on processing power, and make sure performance improves with additional slices (except when it doesn't :P) Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
