Re: ✗ Fi.CI.BAT: warning for drm/i915: Guc code reorg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 9/30/2017 3:26 AM, Michal Wajdeczko wrote:
On Fri, 29 Sep 2017 20:07:48 +0200, Patchwork <patchwork@xxxxxxxxxxxxxxxxxxxxxx> wrote:

== Series Details ==

Series: drm/i915: Guc code reorg
URL   : https://patchwork.freedesktop.org/series/31199/
State : warning

== Summary ==

Series 31199v1 drm/i915: Guc code reorg
https://patchwork.freedesktop.org/api/1.0/series/31199/revisions/1/mbox/

Test chamelium:
        Subgroup dp-edid-read:
                pass       -> FAIL       (fi-kbl-7500u) fdo#102672
        Subgroup hdmi-crc-fast:
                dmesg-warn -> PASS       (fi-skl-6700k) fdo#103019
Test kms_busy:
        Subgroup basic-flip-c:
                incomplete -> PASS       (fi-bxt-j4205) fdo#102035
Test drv_module_reload:
        Subgroup basic-reload:
                pass       -> DMESG-WARN (fi-snb-2520m)
                pass       -> DMESG-WARN (fi-snb-2600)
                pass       -> DMESG-WARN (fi-ivb-3520m)
                pass       -> DMESG-WARN (fi-ivb-3770)
                pass       -> DMESG-WARN (fi-byt-j1900)
                pass       -> DMESG-WARN (fi-byt-n2820)
                pass       -> DMESG-WARN (fi-hsw-4770)
                pass       -> DMESG-WARN (fi-hsw-4770r)
                pass       -> DMESG-WARN (fi-bdw-5557u)
                pass       -> DMESG-WARN (fi-bdw-gvtdvm)
        Subgroup basic-no-display:
                pass       -> DMESG-WARN (fi-snb-2520m)
                pass       -> DMESG-WARN (fi-snb-2600)
                pass       -> DMESG-WARN (fi-ivb-3520m)
                pass       -> DMESG-WARN (fi-ivb-3770)
                pass       -> DMESG-WARN (fi-byt-j1900)
                pass       -> DMESG-WARN (fi-byt-n2820)
                pass       -> DMESG-WARN (fi-hsw-4770)
                pass       -> DMESG-WARN (fi-hsw-4770r)
                pass       -> DMESG-WARN (fi-bdw-5557u)
                pass       -> DMESG-WARN (fi-bdw-gvtdvm)
        Subgroup basic-reload-inject:
                pass       -> DMESG-WARN (fi-snb-2520m)
                pass       -> DMESG-WARN (fi-snb-2600)
                pass       -> DMESG-WARN (fi-ivb-3520m)
                pass       -> DMESG-WARN (fi-ivb-3770)
                pass       -> DMESG-WARN (fi-byt-j1900)
                pass       -> DMESG-WARN (fi-byt-n2820)
                pass       -> DMESG-WARN (fi-hsw-4770)
                pass       -> DMESG-WARN (fi-hsw-4770r)
                pass       -> DMESG-WARN (fi-bdw-5557u)
                pass       -> DMESG-WARN (fi-bdw-gvtdvm)
                dmesg-warn -> PASS       (fi-glk-1) fdo#102777

fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
fdo#103019 https://bugs.freedesktop.org/show_bug.cgi?id=103019
fdo#102035 https://bugs.freedesktop.org/show_bug.cgi?id=102035
fdo#102777 https://bugs.freedesktop.org/show_bug.cgi?id=102777

fi-bdw-5557u     total:289  pass:265  dwarn:3   dfail:0 fail:0   skip:21  time:440s fi-bdw-gvtdvm    total:289  pass:262  dwarn:3   dfail:0 fail:0   skip:24  time:474s fi-blb-e6850     total:289  pass:224  dwarn:1   dfail:0 fail:0   skip:64  time:419s fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0 fail:0   skip:46  time:523s fi-bwr-2160      total:289  pass:184  dwarn:0   dfail:0 fail:0   skip:105 time:278s fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0 fail:0   skip:30  time:496s fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0 fail:0   skip:29  time:514s fi-byt-j1900     total:289  pass:251  dwarn:4   dfail:0 fail:0   skip:34  time:499s fi-byt-n2820     total:289  pass:247  dwarn:4   dfail:0 fail:0   skip:38  time:478s fi-cfl-s         total:289  pass:256  dwarn:1   dfail:0 fail:0   skip:32  time:557s fi-cnl-y         total:289  pass:261  dwarn:1   dfail:0 fail:0   skip:27  time:644s fi-elk-e7500     total:289  pass:230  dwarn:0   dfail:0 fail:0   skip:59  time:415s fi-glk-1         total:289  pass:260  dwarn:0   dfail:0 fail:0   skip:29  time:568s fi-hsw-4770      total:289  pass:260  dwarn:3   dfail:0 fail:0   skip:26  time:423s fi-hsw-4770r     total:289  pass:260  dwarn:3   dfail:0 fail:0   skip:26  time:409s fi-ilk-650       total:289  pass:229  dwarn:0   dfail:0 fail:0   skip:60  time:436s fi-ivb-3520m     total:289  pass:258  dwarn:3   dfail:0 fail:0   skip:28  time:491s fi-ivb-3770      total:289  pass:258  dwarn:3   dfail:0 fail:0   skip:28  time:465s fi-kbl-7500u     total:289  pass:263  dwarn:1   dfail:0 fail:1   skip:24  time:474s fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0 fail:0   skip:19  time:581s fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0 fail:0   skip:27  time:590s fi-pnv-d510      total:289  pass:223  dwarn:1   dfail:0 fail:0   skip:65  time:542s fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0 fail:0   skip:20  time:450s fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0 fail:0   skip:24  time:755s fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0 fail:0   skip:20  time:488s fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0 fail:0   skip:23  time:473s fi-snb-2520m     total:289  pass:248  dwarn:3   dfail:0 fail:0   skip:38  time:572s fi-snb-2600      total:289  pass:247  dwarn:3   dfail:0 fail:0   skip:39  time:412s

e650b9cdaff616445f38986379b1c0c4b03a4282 drm-tip: 2017y-09m-29d-11h-52m-41s UTC integration manifest
6d4769343a2a drm/i915: Move intel_guc_allocate_vma to guc.c
59480c574191 drm/i915: Move intel_guc_suspend/resume to guc.c
d2893f8cbf4e drm/i915: Move intel_guc_auth_huc to guc.c
1a0dd7cc4a5f drm/i915: Move intel_guc_sample_forcewake to guc.c
4fca849cd959 drm/i915: Move core GuC functions into dedicated file
80014876b93d drm/i915: Move GuC declarations into dedicated header
0ca0dc99d1b8 drm/i915: Move HuC declarations into dedicated header
e47aeb8fe88c drm/i915: Move uC fw helper code into dedicated files
c09aa8ff2ac9 drm/i915: Drop unnecessary forward declaration

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5863/


Hmm, I'm not sure that these WARN_ON are correct. What about removing them?
Pulling out guc_init_send_regs from guc_init_early and calling it as part of i915_driver_init_mmio post intel_uncore_init is
proper order.

diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index b3c3f94..5fcc562 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -1836,8 +1836,6 @@ intel_uncore_forcewake_for_read(struct drm_i915_private *dev_priv,
                fw_domains = 0;
        }

-       WARN_ON(fw_domains & ~dev_priv->uncore.fw_domains);
-
        return fw_domains;
 }

@@ -1859,8 +1857,6 @@ intel_uncore_forcewake_for_write(struct drm_i915_private *dev_priv,
                fw_domains = 0;
        }

-       WARN_ON(fw_domains & ~dev_priv->uncore.fw_domains);
-
        return fw_domains;
 }

Michal

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux