An adventure that started from a reported build error that was easy to see why it happened, but not as easy to see why it didn't happen on my end. A user attempted to build IGT with a cairo that was built without glib. That revealed a spot of code that unconditionally used glib headers, making everything in IGT depend on glib headers. Why everything worked was because glib's cflags come with cairo's cflags typically [citation needed]. Fixing that revealed a couple of missing includes that glib.h ended up providing. Petri Latvala (3): kms_atomic_interruptible: Add missing #include gem_exec_schedule: Add missing #include lib: Reduce dependency on glib lib/Makefile.sources | 1 + lib/igt_chamelium.c | 1 + lib/igt_core.c | 3 +++ lib/igt_core.h | 2 -- lib/igt_rc.h | 34 ++++++++++++++++++++++++++++++++++ lib/meson.build | 1 + tests/gem_exec_schedule.c | 1 + tests/kms_atomic_interruptible.c | 2 ++ 8 files changed, 43 insertions(+), 2 deletions(-) create mode 100644 lib/igt_rc.h -- 2.14.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
