On Wed, 2017-09-27 at 11:22 +0000, Michal Wajdeczko wrote: > While here fix param and var types to match new naming rules. > > v2: update names and commit message (Sagar) > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > Cc: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx> Generally, when the function ends up being used only from single .c file, you may drop the intel_ prefix and just have it as a private inline. So in intel_uc.c as "guc_wopcm_size". We should try to have the related code in same files and avoid having functions in the .h files to the extent we can. For example here this is very much an implementation detail. When moved there with the rename, this is; Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
