Quoting Rodrigo Vivi (2017-09-28 20:12:14)
> On Thu, Sep 28, 2017 at 07:02:59PM +0000, Chris Wilson wrote:
> > Quoting Rodrigo Vivi (2017-09-28 19:51:48)
> > > Although Bspec state this Workaround is only relevant for SKL:All.
> > >
> > > The wa_database state this is needed for All platforms from SKL to CNL.
> > >
> > > So let's pick the safest case.
> > >
> > > Cc: Mahesh Kumar <mahesh1.kumar@xxxxxxxxx>
> > > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> > > ---
> > > drivers/gpu/drm/i915/intel_pm.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > > index ede871b7982e..27f9d5ab2d23 100644
> > > --- a/drivers/gpu/drm/i915/intel_pm.c
> > > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > > @@ -5828,8 +5828,8 @@ void intel_enable_ipc(struct drm_i915_private *dev_priv)
> > > {
> > > u32 val;
> > >
> > > - /* Display WA #0477 WaDisableIPC: skl */
> > > - if (IS_SKYLAKE(dev_priv)) {
> > > + /* Display WA #0477 WaDisableIPC: skl,kbl,bxt,glk,cfl,cnl */
> > > + if (INTEL_GEN(dev_priv) <= 10) {
> >
> > But at that point, why not just define has_ipc as a gen10 feature?
>
> it's already there...
>
> > You
> > can have a comment before gen9 feature that although IPC was introduced
> > for gen9, it is recommended (w/a) to leave disabled.
>
> so you mean moving this Wa from here to set has_ipc = 0 to all platforms?
>
> Anyways I'd like to hear from Manesh about it since this basically revert
> all IPC work for all platforms...
Just the gen9 platforms, gen10+ enables it.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
